add sglang reasoning parser by eliasyin · Pull Request #7171 · modelscope/ms-swift

Summary of Changes

Hello @eliasyin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the SglangEngine by adding robust parsing capabilities for Large Language Model responses. The core purpose is to enable the extraction and clear separation of a model's internal reasoning process, typically indicated by specific tags, from its direct answer. This improvement provides a more structured and transparent way to handle LLM outputs, making both the thought process and the final result readily accessible within the ChatMessage object.

Highlights

  • Reasoning Content Extraction: A new utility function, extract_reasoning_content, has been introduced in sglang_engine.py. This function is designed to parse LLM responses, specifically looking for content enclosed within <think> and </think> tags to separate the model's reasoning from its final answer.
  • SglangEngine Integration: The _create_chat_completion_response method within the SglangEngine has been updated to utilize the new extract_reasoning_content parser. This ensures that responses from 'thinking models' are processed to distinguish between the reasoning steps and the ultimate output.
  • Enhanced ChatMessage Structure: The ChatMessage object now includes a new field, reasoning_content. This allows the extracted reasoning process to be stored separately from the final content of the message, providing a more granular and informative representation of the LLM's output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.