Fix Netty event loop resource leak on MongoClient close. by vbabanin · Pull Request #1646 · mongodb/mongo-java-driver
Navigation Menu
{{ message }}
mongodb / mongo-java-driver Public
- Notifications You must be signed in to change notification settings
- Fork 1.5k
Merged
Fix Netty event loop resource leak on MongoClient close.#1646
vbabanin merged 3 commits intomongodb:mainfrom
Fix Netty event loop resource leak on MongoClient close.#1646
vbabanin merged 3 commits intomongodb:mainfrom
Conversation
vbabanin added 2 commits
March 12, 2025 17:35JAVA-5812
vbabanin
requested review from
a team and
NathanQingyangXu
and removed request for
a team
vbabanin
self-assigned this
vbabanin
requested review from
katcharov
and removed request for
NathanQingyangXu
vbabanin commented Mar 13, 2025
| public MongoClientImpl(final Cluster cluster, | ||
| final MongoClientSettings settings, | ||
| final MongoDriverInformation mongoDriverInformation, | ||
| @Nullable final AutoCloseable externalResourceCloser) { |
Copy link
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change aligns with the implementation in MongoClientImpl for the reactive-streams driver, as detailed here: MongoClientImpl Code.
vbabanin
mentioned this pull request
vbabanin
requested a review
from rozza
katcharov reviewed Mar 24, 2025
driver-sync/src/main/com/mongodb/client/internal/MongoClientImpl.java
Show resolved
Hide resolved
driver-sync/src/main/com/mongodb/client/internal/MongoClientImpl.java Show resolved Hide resolved
vbabanin
requested a review
from katcharov
rozza approved these changes Mar 25, 2025
Copy link
Member
rozza
left a comment
rozza
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
katcharov approved these changes Mar 25, 2025
vbabanin added a commit to vbabanin/mongo-java-driver that referenced this pull request
Apr 4, 2025
vbabanin
mentioned this pull request
vbabanin added a commit that referenced this pull request
Apr 9, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants