Add String cache for BsonArray indexes. by vbabanin · Pull Request #1664 · mongodb/mongo-java-driver
Navigation Menu
{{ message }}
mongodb / mongo-java-driver Public
- Notifications You must be signed in to change notification settings
- Fork 1.5k
Merged
Add String cache for BsonArray indexes.#1664
vbabanin merged 6 commits intomongodb:mainfrom
Add String cache for BsonArray indexes.#1664
vbabanin merged 6 commits intomongodb:mainfrom
Conversation
vbabanin added 3 commits
March 28, 2025 18:26
vbabanin
self-assigned this
vbabanin added 2 commits
March 31, 2025 21:25
vbabanin
marked this pull request as ready for review
vbabanin
requested a review
from rozza
rozza approved these changes Apr 1, 2025
Copy link
Member
rozza
left a comment
rozza
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One optional suggestion.
bson/src/main/org/bson/BsonBinaryWriter.java
Outdated
Show resolved
Hide resolved
bson/src/main/org/bson/BsonBinaryWriter.java Outdated Show resolved Hide resolved
Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
Copy link
Member
ShaneHarvey
commented
Apr 2, 2025
ShaneHarvey commented
Apr 2, 2025FYI we cache the first 1000 keys in Python: https://github.com/mongodb/mongo-python-driver/blob/4.11.3/bson/__init__.py#L646
vbabanin
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants