Improve the `toCollection` and related API documentation by stIncMale · Pull Request #1677 · mongodb/mongo-java-driver

Conversation

@stIncMale

@rozza is the primary reviewer (chosen automatically), @katcharov is the secondary one (chosen manually based on the GitHub suggestion).

JAVA-5833

@stIncMale stIncMale marked this pull request as ready for review

April 9, 2025 23:33
…shouldHaveTheSameMethods`

JAVA-5833

@stIncMale

We have the same test failures here, where they are obviously not caused by the change. Therefore, the failures here are also not caused by the changes.

katcharov

@stIncMale

Replaced Ross with @nhachicha, because Ross is away.

katcharov

Comment on lines +218 to +223

/**
* Requests [AggregateFlow] to start streaming data according to the specified aggregation pipeline.
* - If the aggregation pipeline ends with an `$out` or `$merge` stage, then finds all documents in the affected
* namespace and emits them. You may want to use [toCollection] instead.
* - Otherwise, emits no values.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to others that these docs and some others are new, and therefore non-trivial.

nhachicha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comment 👍

nhachicha

nhachicha