Make distinct() work with arrays of dicts by niklasj · Pull Request #751 · mongomock/mongomock

@niklasj

Copy link

Contributor

@niklasj niklasj commented

Jan 31, 2022

Fixes #750.

@pcorpet

Copy link

Member

pcorpet commented

Feb 1, 2022

Very nice fix. Thanks.

@pcorpet

Copy link

Member

pcorpet commented

Feb 1, 2022

I'm not ure why the CI didn't run. Can you try to rebase and push again please?

Fixes mongomock#750.

@codecov

Copy link

codecov bot commented

Feb 2, 2022

edited

Loading

Codecov Report

Merging #751 (548a806) into develop (84e0faf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #751   +/-   ##
========================================
  Coverage    95.07%   95.07%           
========================================
  Files           19       19           
  Lines         3734     3734           
========================================
  Hits          3550     3550           
  Misses         184      184           
Impacted Files Coverage Δ
mongomock/collection.py 92.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e0faf...548a806. Read the comment docs.

@niklasj

Copy link

Contributor Author

niklasj commented

Feb 2, 2022

Sure thing!

@pcorpet

Copy link

Member

pcorpet commented

Feb 2, 2022

Perfect, let's merge!

@pcorpet pcorpet merged commit b507ae6 into mongomock:develop

Feb 2, 2022