Home Original page

asShort in ImmutableLongValueImpl should check isInShortRange by mecp · Pull Request #287 · msgpack/msgpack-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mecp

Copy link Copy Markdown

Contributor

@mecp mecp commented

Nov 4, 2015

asShort() in ImmutableLongvalueImpl should check isInShortRange() instead of isInByteRange()

@mecp

Copy link Copy Markdown

Contributor Author

mecp commented

Nov 4, 2015

Is it possible to do a hotfix/patch release for this?

@komamitsu

Copy link Copy Markdown

Member

@mecp Could you add a test for it?

@mecp

Copy link Copy Markdown

Contributor Author

mecp commented

Nov 10, 2015

@komamitsu I have added tests for range checks and casts. Please don't judge the code, as these are first ever scala lines produced by me. please share If something is inappropriate.

komamitsu added a commit that referenced this pull request

Nov 11, 2015 
asShort in ImmutableLongValueImpl should check isInShortRange

@komamitsu komamitsu merged commit 610553e into msgpack:v07-develop

Nov 11, 2015

@komamitsu

Copy link Copy Markdown

Member

Great. Thanks!

@komamitsu

Copy link Copy Markdown

Member

@mecp Released 0.7.1 that includes this change.

@mecp

Copy link Copy Markdown

Contributor Author

mecp commented

Nov 14, 2015

@komamitsu Arigato.

@Jayseeall222

Copy link Copy Markdown

asShort() in ImmutableLongvalueImpl should check isInShortRange() instead of isInByteRange()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mecp @komamitsu @Jayseeall222