MessagePackFactory should add getFormatName for naming the factory by qxo · Pull Request #515 · msgpack/msgpack-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@qxo

Copy link Copy Markdown

Contributor

@qxo qxo commented

Nov 3, 2019

No description provided.

@xerial xerial requested a review from komamitsu

November 9, 2019 01:09
Copy link Copy Markdown

Member

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@komamitsu komamitsu merged commit ba61279 into msgpack:develop

Nov 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@komamitsu komamitsu komamitsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qxo @komamitsu