#542: Add a warning note for the usage of MessageUnpacker.readPayloadAsReference by xerial · Pull Request #546 · msgpack/msgpack-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@xerial

Copy link Copy Markdown

Member

@xerial xerial commented

Feb 14, 2021

No description provided.

Copy link Copy Markdown

Member

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user of this method can know the buffer length encoded in the header. Even with a wrong length in header encoded by an attacker, it should be safe as long as the user of this method implements safely.

@xerial xerial merged commit 4976b7f into msgpack:develop

Feb 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@komamitsu komamitsu komamitsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xerial @komamitsu