Prevent having two different unpacking methods by cyberdelia · Pull Request #548 · msgpack/msgpack-java
Navigation Menu
{{ message }}
msgpack / msgpack-java Public
- Notifications You must be signed in to change notification settings
- Fork 325
Merged
Prevent having two different unpacking methods#548
xerial merged 2 commits intomsgpack:developfrom
cyberdelia:no-map-land
Prevent having two different unpacking methods#548
xerial merged 2 commits intomsgpack:developfrom
cyberdelia:no-map-land
Conversation
Copy link Copy Markdown
Contributor
cyberdelia
commented
May 11, 2021
cyberdelia
commented
Prevent having two different unpacking methods in the unpacker: unpackValue exclusively use arrays for both arrays and maps , and unpackValue(Variable) uses list and map. This will prevent having two different behaviour when unpacking values and prevent some code duplication.
xerial reviewed May 11, 2021
xerial reviewed May 11, 2021
xerial
merged commit
75d33d1
into
msgpack:develop
Copy link Copy Markdown
Contributor Author
cyberdelia
commented
May 11, 2021
cyberdelia commented
May 11, 2021Well, I'm still worried by the lack of tests failing because of my improper logic copy/pasta.
cyberdelia
deleted the
no-map-land
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants