Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

Support JDK17#660

xerial merged 4 commits intodevelopfrom

jdk17-support

Conversation

@xerial

Copy link Copy Markdown

Member

@xerial xerial commented

Jun 28, 2022

edited

Loading

To use JDK17 + DirectByteBuffer, we need to set two JVM options:

--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED

This PR adds:

  • CI for JDK17
  • Add a workaround even if these JVM options are not set.
  • Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options

Related approaches:

Fixes #600

AcumenDev reacted with thumbs up emoji

@xerial xerial marked this pull request as ready for review

June 28, 2022 09:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not working in 17 JDK

1 participant

@xerial