Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java
Navigation Menu
{{ message }}
msgpack / msgpack-java Public
- Notifications You must be signed in to change notification settings
- Fork 325
Merged
Conversation
Copy link Copy Markdown
Member
To use JDK17 + DirectByteBuffer, we need to set two JVM options:
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
This PR adds:
- CI for JDK17
- Add a workaround even if these JVM options are not set.
- Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options
Related approaches:
- [SPARK-36704][CORE] Expand exception handling to more Java 9 cases where reflection is limited at runtime, when reflecting to manage DirectByteBuffer settings apache/spark#33947
- [SPARK-36796][BUILD][CORE][SQL] Pass all
sql/coreand dependent modules UTs with JDK 17 except one case inpostgreSQL/text.sqlapache/spark#34153 (--add-open JVM options to use reflection access) - Use DirectBuffer interface to get buffer address airlift/slice#130
Fixes #600
xerial added 2 commits
June 28, 2022 17:21
xerial
marked this pull request as ready for review
xerial added 2 commits
June 28, 2022 18:35
xerial
merged commit
117f161
into
develop
xerial
mentioned this pull request
akudiyar
mentioned this pull request
xerial
deleted the
jdk17-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment