Allow parameters in custom test functions by lordjabez · Pull Request #64 · msiemens/tinydb
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 604
Merged
msiemens merged 1 commit intomsiemens:masterfrom
Jul 4, 2015Merged
Conversation
tests/test_queries.py
Outdated
tests/test_queries.py Outdated
Copy link Copy Markdown
Owner
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using a string for 44, not an int. This breaks the tests for Python3 and PyPy3 (see https://travis-ci.org/msiemens/tinydb/builds/68895961).
Copy link Copy Markdown
Owner
msiemens
commented
Jun 30, 2015
msiemens commented
Jun 30, 2015There's a tiny mistake in a test, but otherwise it looks good!
Copy link Copy Markdown
Contributor Author
lordjabez
commented
Jun 30, 2015
lordjabez commented
Jun 30, 2015Should I just remove that test? I only included the string comparison because there was a similar one for the previous test case.
Copy link Copy Markdown
Contributor Author
lordjabez
commented
Jun 30, 2015
lordjabez commented
Jun 30, 2015Ahh, I see the issue now. I'll simply remove the test.
lordjabez
force-pushed
the
feature/arbitrary-parameters-for-custom-test
branch
from
235902d to
9f55011
Compare
msiemens added a commit that referenced this pull request
Jul 4, 2015…r-custom-test Allow parameters in custom test functions
msiemens
merged commit
10a93cd
into
msiemens:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants