Fix feature size calculation and add error handling for KMeans training by stelfrag · Pull Request #21155 · netdata/netdata
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 6.4k
Merged
stelfrag merged 1 commit intonetdata:masterfrom
Oct 16, 2025Merged
Fix feature size calculation and add error handling for KMeans training#21155
stelfrag merged 1 commit intonetdata:masterfrom
Fix feature size calculation and add error handling for KMeans training#21155
stelfrag merged 1 commit intonetdata:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
stelfrag
commented
Oct 16, 2025
stelfrag
commented
Summary
- Allocate enough elements in the vector to prevent buffer overflow
- Add check to ensure we have at least 2 data points (ml_kmeans_train)
stelfrag
marked this pull request as ready for review
stelfrag
requested a review
from vkalintiris
as a code owner
thiagoftsm approved these changes Oct 16, 2025
Copy link Copy Markdown
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After compile this PR, no issue was reported locally.. LGTM!
stelfrag
deleted the
fix_ml_crash1
branch
stelfrag added a commit to stelfrag/netdata that referenced this pull request
Oct 27, 2025…ng (netdata#21155) (cherry picked from commit d22056f)
stelfrag
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment