Home Original page

Cleanup win plugin (Remove MSSQL) by thiagoftsm · Pull Request #21876 · netdata/netdata

Conversation

@thiagoftsm

@thiagoftsm thiagoftsm commented

Mar 3, 2026

•

edited by cubic-dev-ai bot

Loading

Summary

This PR implements changes informed in latest release notes.

Test Plan
  • AI-generated or AI-assisted content has been manually verified (examples/instructions tested where applicable).
Additional Information
For users: How does this change affect me?

Summary by cubic

Removed MSSQL monitoring from the Windows plugin to simplify maintenance and reduce build complexity. This drops the PerflibMSSQL module and all related sources and docs.

  • Refactors

    • Removed MonitorSQL.c, perflib-mssql.c, and perflib-mssql-queries.h.
    • Deleted PerflibMSSQL registration and cleanup hooks in windows_plugin.c and windows_plugin.h.
    • Cleaned CMakeLists to stop compiling MSSQL sources.
    • Removed MSSQL references from README and metadata.yaml.

  • Migration

    • MSSQL settings in windows.plugin.conf are ignored; use an external SQL Server exporter if needed.

Written for commit 7b493b4. Summary will update on new commits.

cubic-dev-ai[bot]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram 
sequenceDiagram
    participant WP as Windows Plugin (Main)
    participant WPR as Windows Performance Registry
    participant MSSQL as MSSQL Server (via ODBC)
    participant Agent as Netdata Agent

    Note over WP, MSSQL: PR Impact: Removal of MSSQL Monitoring (Cleanup)

    WP->>WP: CHANGED: Register modules (PerflibMSSQL entry removed from module array)

    loop Data Collection Loop
        WP->>WPR: Request system counters (CPU, Memory, Network)
        WPR-->>WP: System performance data
        
        Note over WP, MSSQL: All MSSQL-specific logic has been decoupled
        
        alt Previous Path (REMOVED)
            WP-xWPR: REMOVED: Fetch MSSQL Perflib objects (perflib-mssql.c)
            WP-xMSSQL: REMOVED: Execute SQL health/performance queries (MonitorSQL.c)
        end

        WP->>Agent: Update non-SQL charts (rrdset_done)
    end

    Note over WP, Agent: Windows MSSQL metrics are no longer collected or exported.
Loading

Labels

1 participant

@thiagoftsm