Strings improvement: trim ZWSP char by CrazyMuffin · Pull Request #304 · nette/utils
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 153
Merged
Conversation
Copy link
Contributor
CrazyMuffin
commented
Oct 30, 2023
CrazyMuffin
commented
- new feature
- BC break? yes - if someone relies on having ZWSP non-trimmed while using default parameter.
- doc PR: Not needed, function is covered and does not mention the default characters
Sneaky Zero-Width Space char \u{200B} is currently untrimmed by trim function, while I'd expect it to do so.
Workaround:
- Fork or extend the class and overwrite default param
- Manually set updated charlist as second argument to every
trim()call
CrazyMuffin added 2 commits
October 30, 2023 12:38Copy link
Member
dg
commented
Oct 30, 2023
dg commented
Oct 30, 2023Thanks
dg
merged commit
4b7b01e
into
nette:master
dg pushed a commit that referenced this pull request
Nov 1, 2023dg pushed a commit that referenced this pull request
Nov 21, 2023This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment