Improve answering calls by anakin78z ยท Pull Request #6015 ยท nextcloud/talk-android
Fixes some of the biggest annoyances with answering calls:
- Allow answering a call from a locked phone without having to unlock the phone after answering. join call without unlock screen #1667 (kind of?)
- Stop calls from ringing after answering. The ringing doesn't stop #5992
- Update the incoming call notification to allow users to answer or decline. Call notification is not actually call #5922
- Show caller avatar on incoming call notification
๐ผ๏ธ Screenshots
๐ง TODO
There are a lot of other issues with calls. This is meant as some small changes that can have a big impact on usability.
๐ Checklist
- โ๏ธ Tests (unit and/or integration) are included or not needed
- ๐ Capability is checked or not needed
- ๐ Backport requests are created or not needed:
/backport to stable-xx.x - ๐ Milestone is set
- ๐ธ PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Thank you for contributing @anakin78z ๐
We will review this soon (will try today but i'm on vacation next week).
As a side note, depending on if #5928 is merged first, there could be more merge conflicts.
Thanks. I'm also waiting to hear back about thstyl2000#1 since they have a massive refactor plan. I'm not sure what stage they're at with implementation though.
and i oversaw it's "just" a draft for now. Just set the state when it's ready to review and let us know if you have questions.
Switched call notification to NotificationCompat.CallStyle. This adds answer/decline buttons to the notification so that users can answer incoming calls. Adds caller avatar to notification. Signed-off-by: Jens Zalzala <jens@shakingearthdigital.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what was causing the lock screen to appear after answering a call.
anakin78z
marked this pull request as ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

