add text/org mimetype by zzkt · Pull Request #1205 · nextcloud/text

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

juliusknorr merged 2 commits intonextcloud:masterfrom

zzkt:patch-1

Dec 17, 2020

Merged

add text/org mimetype#1205

juliusknorr merged 2 commits intonextcloud:masterfrom

zzkt:patch-1

Conversation

@zzkt

Copy link Copy Markdown

Contributor

@zzkt zzkt commented

Nov 27, 2020

edited

Loading

Summary

@juliusknorr

Copy link Copy Markdown

Member

Won't help (yet) as the mime type is probably not detected by https://www.php.net/manual/de/function.mime-content-type.php or the mimetype-mapping in the server, so either one of those should happen first 😉

@zzkt

Copy link Copy Markdown

Contributor Author

zzkt commented

Dec 1, 2020

Agreed. It's one piece of the puzzle, but between mod_mime and Mimetype mapping it's a bit closer to editing org formatted text files in the nextcloud text editor...

@juliusknorr

Copy link Copy Markdown

Member

Would you be up for opening a pull request to the server repo to add the mimetype mapping by default. With that we could then merge the text app pr from my PoV.

Feel free to have a look at nextcloud/server@9708b00 for a reference implementation.

@zzkt

Copy link Copy Markdown

Contributor Author

zzkt commented

Dec 1, 2020

@zzkt

Copy link Copy Markdown

Contributor Author

zzkt commented

Dec 16, 2020

@juliushaertl the changes in nextcloud/server#24488 have been merged, is there anything else required to merge this?

@juliusknorr

Copy link Copy Markdown

Member

CI failure unrelated.

@juliusknorr juliusknorr merged commit 5f5dd32 into nextcloud:master

Dec 17, 2020

@juliusknorr juliusknorr added this to the Nextcloud 21 milestone

Dec 17, 2020

@juliusknorr juliusknorr added the enhancement

New feature or request

label

Dec 17, 2020

@zzkt zzkt deleted the patch-1 branch

December 17, 2020 14:05

@rullzer rullzer mentioned this pull request

Dec 18, 2020

59 tasks

@zzkt zzkt changed the title add text/org mimetype #394 add text/org mimetype

Jan 12, 2021

@zzkt zzkt mentioned this pull request

Mar 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

enhancement

New feature or request

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

2 participants

@zzkt @juliusknorr