add text/org mimetype by zzkt · Pull Request #1205 · nextcloud/text
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 116
Merged
Conversation
Copy link Copy Markdown
Contributor
- Contributes to: Support more file extensions #394
- Target version: master
Summary
Copy link Copy Markdown
Member
juliusknorr
commented
Dec 1, 2020
juliusknorr commented
Dec 1, 2020Won't help (yet) as the mime type is probably not detected by https://www.php.net/manual/de/function.mime-content-type.php or the mimetype-mapping in the server, so either one of those should happen first 😉
Copy link Copy Markdown
Contributor Author
zzkt
commented
Dec 1, 2020
zzkt commented
Dec 1, 2020Agreed. It's one piece of the puzzle, but between mod_mime and Mimetype mapping it's a bit closer to editing org formatted text files in the nextcloud text editor...
Copy link Copy Markdown
Member
juliusknorr
commented
Dec 1, 2020
juliusknorr commented
Dec 1, 2020Would you be up for opening a pull request to the server repo to add the mimetype mapping by default. With that we could then merge the text app pr from my PoV.
Feel free to have a look at nextcloud/server@9708b00 for a reference implementation.
zzkt
mentioned this pull request
Copy link Copy Markdown
Contributor Author
zzkt
commented
Dec 1, 2020
zzkt commented
Dec 1, 2020...added nextcloud/server#24488
zzkt added 2 commits
December 15, 2020 18:17Signed-off-by: nik gaffney <nik@fo.am>
Copy link Copy Markdown
Contributor Author
zzkt
commented
Dec 16, 2020
zzkt commented
Dec 16, 2020@juliushaertl the changes in nextcloud/server#24488 have been merged, is there anything else required to merge this?
juliusknorr approved these changes Dec 17, 2020
Copy link Copy Markdown
Member
juliusknorr
commented
Dec 17, 2020
juliusknorr commented
Dec 17, 2020CI failure unrelated.
juliusknorr
merged commit
5f5dd32
into
nextcloud:master
juliusknorr
added this to the
Nextcloud 21 milestone
zzkt
deleted the
patch-1
branch
zzkt
changed the title
add text/org mimetype #394
add text/org mimetype
zzkt
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment