chore: Add config lexicon by juliusknorr · Pull Request #8083 · nextcloud/text

chore: Add config lexicon by juliusknorr · Pull Request #8083 · nextcloud/text

Base automatically changed from fix/psalm-deprecation to main

December 19, 2025 22:00

Signed-off-by: Julius Knorr <jus@bitgrid.net>

Signed-off-by: Julius Knorr <jus@bitgrid.net>

Code changes look good to me, but I don't see the ConfigLexicon class being used anywhere. Also I don't know the concept of a ConfigLexicon yet. Can I read up somewhere about its purpose?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra pointers @juliusknorr. I have some nitpicking comments about the wording of the descriptions. If you agree with the suggested changes, I can also take care of them to not put more work on your shoulders.

		key: 'default_file_extension',
		type: ValueType::STRING,
		defaultRaw: 'md',
		definition: 'Default file extension for new text files',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	definition: 'Default file extension for new text files',
	definition: 'Default file extension for new text files (usually \'md\' or \'txt\')',

		key: 'open_read_only_enabled',
		type: ValueType::BOOL,
		defaultRaw: false,
		definition: 'Whether opening files in read-only mode is enabled',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	definition: 'Whether opening files in read-only mode is enabled',
	definition: 'Whether files are opened in read-only mode per default',

		key: 'workspace_available',
		type: ValueType::BOOL,
		defaultRaw: true,
		definition: 'Whether rich workspace feature is available',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	definition: 'Whether rich workspace feature is available',
	definition: 'Whether folder description feature (previously called rich workspace) is available',

		key: 'notify_push',
		type: ValueType::BOOL,
		defaultRaw: true,
		definition: 'Whether notify_push synchronization is enabled',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	definition: 'Whether notify_push synchronization is enabled',
	definition: 'Whether notify_push is used for real-time synchronization if available',

		key: 'workspace_enabled',
		type: ValueType::BOOL,
		defaultRaw: true,
		definition: 'Whether rich workspace is enabled for the user',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	definition: 'Whether rich workspace is enabled for the user',
	definition: 'Whether folder description feature (previously called rich workspace) is enabled for the user',