refactor: adjust code to comply with code style (again) by susnux · Pull Request #1774 · nextcloud-libraries/nextcloud-dialogs

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@susnux

Copy link Copy Markdown

Contributor

@susnux susnux commented

May 11, 2025

Noticed we do not have a linting CI here so we did not notice we merged stuff not complying with ESLint.
So this does:

  • Fix code style and logic issues where needed
  • Add CI job for ESLint

@susnux susnux requested review from ShGKme and skjnldsv

May 11, 2025 15:19

@susnux susnux requested a review from ShGKme

May 12, 2025 07:46

susnux added 2 commits

May 12, 2025 09:47
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

@susnux susnux force-pushed the refactor/code-style branch from 3433193 to 684ebe2 Compare

May 12, 2025 08:05

@skjnldsv skjnldsv merged commit 2ac2ef2 into main

May 12, 2025

12 checks passed

@skjnldsv skjnldsv deleted the refactor/code-style branch

May 12, 2025 08:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @skjnldsv @ShGKme