fix: add allowCreateNew to filepicker by grnd-alt · Pull Request #2070

fix: add allowCreateNew to filepicker by grnd-alt · Pull Request #2070 · nextcloud-libraries/nextcloud-dialogs

grnd-alt linked an issue

Oct 28, 2025

that may be closed by this pull request

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.85%. Comparing base (c277589) to head (af199ae).
⚠️ Report is 106 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/filepicker-builder.ts	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
- Coverage   46.38%   45.85%   -0.54%     
==========================================
  Files          15       15              
  Lines         429      434       +5     
  Branches       82       83       +1     
==========================================
  Hits          199      199              
- Misses        202      207       +5     
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

		path?: string
		}>(), {
		allowPickDirectory: false,
		allowCreateNew: false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like this default would be better off to be true but allowPickDirectory has a default of false and they maybe should be consistent?!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use noMenu with default false

I think it would be good to call the pop noMenu with default false.
In the builder call it maybe setMenu or similar to disable it (so here the menu is also on by default).

Signed-off-by: grnd-alt <github@belakkaf.net>

grnd-alt deleted the fix/1893-unclear-allowdirectories-behavior branch

November 26, 2025 09:30