refactor: update to `@nextcloud/files` v4 and adjust code by susnux · Pull Request #2275 · nextcloud-libraries/nextcloud-dialogs

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@susnux

Copy link Copy Markdown

Contributor

@susnux susnux commented

Feb 10, 2026

  • update to v4 files library to reduce dependencies on current versions of apps
  • adjust code for changes in v4
  • remove cancelable promise

@susnux susnux added dependencies

Pull requests that update a dependency file

3. to review labels

Feb 10, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

@codecov

Copy link Copy Markdown

codecov bot commented

Feb 10, 2026

edited

Loading

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.79%. Comparing base (1172c7c) to head (6488466).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/composables/dav.ts 88.00% 2 Missing and 1 partial ⚠️
lib/filepicker-builder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   45.43%   43.79%   -1.64%     
==========================================
  Files          15       15              
  Lines         438      427      -11     
  Branches       84       82       -2     
==========================================
- Hits          199      187      -12     
  Misses        211      211              
- Partials       28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux merged commit 6e6350e into main

Feb 10, 2026

15 checks passed

@susnux susnux deleted the chore/files-v4 branch

February 10, 2026 22:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@cristianscheid cristianscheid Awaiting requested review from cristianscheid

Assignees

No one assigned

Labels

3. to review dependencies

Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@susnux @AndyScherzinger