Fix: Warning for shadowed variables (#3188) by kernie · Pull Request #3193 · nlohmann/json
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 7.3k
Comments
Merged
Fix: Warning for shadowed variables (#3188)#3193
nlohmann merged 2 commits intonlohmann:developfrom
kernie:develop
Fix: Warning for shadowed variables (#3188)#3193
nlohmann merged 2 commits intonlohmann:developfrom
kernie:develop
Conversation
Copy link
Contributor
kernie
commented
Dec 14, 2021
kernie
commented
Simple variable renaming to avoid warning about shadowed variable
Pull request checklist
Read the Contribution Guidelines for detailed information.
- Changes are described in the pull request, or an existing issue is referenced.
- The test suite compiles and runs without error.
- Code coverage is 100%. Test cases can be added by editing the test suite.
- The source code is amalgamated; that is, after making changes to the sources in the
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.
kernie added 2 commits
December 14, 2021 09:42
kernie
requested a review
from nlohmann
as a code owner
Copy link
coveralls
commented
Dec 14, 2021
coveralls commented
Dec 14, 2021nlohmann approved these changes Dec 17, 2021
Copy link
Owner
nlohmann
left a comment
nlohmann
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
nlohmann
self-assigned this
nlohmann
added this to the
Release 3.10.5 milestone
nlohmann
added
the
release item: 🔨 further change
label
nlohmann
merged commit
825d323
into
nlohmann:develop
Copy link
Owner
nlohmann
commented
Dec 17, 2021
nlohmann commented
Dec 17, 2021Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment