CI: windows-2016 has been deprecated; remove jobs by falbrechtskirchinger · Pull Request #3416 · nlohmann/json
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 7.3k
Comments
Merged
nlohmann merged 1 commit intonlohmann:developfrom
Apr 4, 2022Merged
CI: windows-2016 has been deprecated; remove jobs#3416
nlohmann merged 1 commit intonlohmann:developfrom
CI: windows-2016 has been deprecated; remove jobs#3416
nlohmann merged 1 commit intonlohmann:developfrom
Conversation
Copy link
Contributor
falbrechtskirchinger
commented
Apr 4, 2022
falbrechtskirchinger
commented
As previously mentioned windows-2016 is now deprecated. Remove msvc2017* jobs from the workflow.
GH offers no replacement for jobs requiring "Visual Studio 15 2017".
falbrechtskirchinger
requested a review
from nlohmann
as a code owner
nlohmann
removed their request for review
nlohmann requested changes Apr 4, 2022
Copy link
Owner
nlohmann
left a comment
nlohmann
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also update the README section and remove the lines for MSVC 2017?
Copy link
falbrechtskirchinger
force-pushed
the
drop-windows-2016
branch
from
1d33c5e to
9d11f0a
Compare
Copy link
Contributor Author
falbrechtskirchinger
commented
Apr 4, 2022
falbrechtskirchinger commented
Apr 4, 2022Done.
The compiler list in README needs a thorough update at some point. GCC 11 (experimental) doesn't seem right, for example.
falbrechtskirchinger
requested a review
from nlohmann
nlohmann approved these changes Apr 4, 2022
Copy link
Owner
nlohmann
left a comment
nlohmann
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
nlohmann
self-assigned this
nlohmann
added
the
release item: 🔨 further change
label
nlohmann
added this to the
Release 3.10.6 milestone
nlohmann
merged commit
33b75e5
into
nlohmann:develop
Copy link
Owner
nlohmann
commented
Apr 4, 2022
nlohmann commented
Apr 4, 2022Thanks!
falbrechtskirchinger
deleted the
drop-windows-2016
branch
Copy link
Owner
nlohmann
commented
Apr 6, 2022
nlohmann commented
Apr 6, 2022Done.
The compiler list in README needs a thorough update at some point. GCC 11 (experimental) doesn't seem right, for example.
Fixed in #3420.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment