Exclude std::any from implicit conversion (fixes #3428) by falbrechtskirchinger · Pull Request #3437 · nlohmann/json

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@falbrechtskirchinger

Copy link

Contributor

Fixes #3428 (MSVC) and silences compiler warning on GCC (-Wconversion).

kotori2 reacted with thumbs up emoji
Fixes nlohmann#3428 (MSVC) and silences compiler warning on GCC (-Wconversion).

@coveralls

Copy link

coveralls commented

Apr 12, 2022

edited

Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a41b003 on falbrechtskirchinger:fix-issue-3428 into 1034490 on nlohmann:develop.

Copy link

Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this

Apr 12, 2022

@nlohmann nlohmann added this to the Release 3.11.0 milestone

Apr 12, 2022

@nlohmann nlohmann merged commit 1deeb43 into nlohmann:develop

Apr 12, 2022

@nlohmann

Copy link

Owner

Thanks!

falbrechtskirchinger reacted with thumbs up emoji

@falbrechtskirchinger falbrechtskirchinger deleted the fix-issue-3428 branch

April 12, 2022 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Projects

None yet

Milestone

Release 3.11.0

Development

Successfully merging this pull request may close these issues.

Error occurred when converting nlohmann::json to std::any

3 participants

@falbrechtskirchinger @coveralls @nlohmann