Add missing files to release artifacts by falbrechtskirchinger · Pull Request #3728 · nlohmann/json
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 7.3k
Comments
Merged
nlohmann merged 2 commits intonlohmann:developfrom
Sep 25, 2022Merged
Add missing files to release artifacts#3728
nlohmann merged 2 commits intonlohmann:developfrom
Add missing files to release artifacts#3728
nlohmann merged 2 commits intonlohmann:developfrom
Conversation
Copy link
Contributor
falbrechtskirchinger
requested a review
from nlohmann
as a code owner
github-actions
bot
added
the
S
label
Copy link
Contributor Author
$ make include.zip
(...)
adding: single_include/nlohmann/json_fwd.hpp (deflated 74%)
adding: BUILD.bazel (deflated 81%)
adding: WORKSPACE.bazel (stored 0%)
falbrechtskirchinger
marked this pull request as draft
Copy link
Contributor Author
falbrechtskirchinger
commented
Sep 7, 2022
falbrechtskirchinger commented
Sep 7, 2022(Let's wait on #3709.)
Copy link
falbrechtskirchinger added 2 commits
September 20, 2022 08:38
falbrechtskirchinger
force-pushed
the
add-missing-release-files
branch
from
6e131c4 to
2b3a1d4
Compare
falbrechtskirchinger
marked this pull request as ready for review
gregmarr approved these changes Sep 21, 2022
nlohmann
added this to the
Release 3.11.3 milestone
nlohmann approved these changes Sep 25, 2022
Copy link
Owner
nlohmann
left a comment
nlohmann
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
nlohmann
merged commit
17d9eac
into
nlohmann:develop
Copy link
Owner
nlohmann
commented
Sep 25, 2022
nlohmann commented
Sep 25, 2022Thanks!
falbrechtskirchinger
deleted the
add-missing-release-files
branch
nlohmann
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment