Home Original page

Support for setting orientation inside progressbar widget by Uriziel01 · Pull Request #39 · nodegui/nodegui

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Uriziel01

Copy link

Contributor

It's also a first pull request to validate my workflow is in fact valid for further development.

a7ul and rgabs reacted with hooray emoji a7ul and rgabs reacted with heart emoji

@a7ul

Copy link

Collaborator

a7ul commented

Aug 22, 2019

•

edited

Loading

Wow!
One tiny addition,
I would also add Orientation to the exports here: https://github.com/nodegui/nodegui/blob/master/src/index.ts
@Uriziel01

@Uriziel01

Copy link

Contributor Author

@master-atul Ohhh I overlooked that part, thanks for pointing it out, I've made the change 👍

@a7ul

Copy link

Collaborator

a7ul commented

Aug 22, 2019

Merging this. Will go out in next release 🍺

Uriziel01 reacted with laugh emoji

@a7ul a7ul merged commit 2011d51 into nodegui:master

Aug 22, 2019

@a7ul

Copy link

Collaborator

a7ul commented

Aug 22, 2019

@all-contributors please add @Uriziel01 for code

@allcontributors

Copy link

Contributor

@master-atul

I've put up a pull request to add @Uriziel01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgabs rgabs rgabs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Uriziel01 @a7ul @rgabs