build,win: fix dll build · nodejs/node@b8c3319

Commit b8c3319

authored and

committed

build,win: fix dll build

Fixes: #58208 PR-URL: #58357 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

lines changed

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,11 @@ BuiltinLoader::BuiltinLoader()`
`64`	`64`	`#endif // HAVE_AMARO`
`65`	`65`	`}`
`66`	`66`
	`67`	`+std::ranges::keys_view<std::ranges::ref_view<const BuiltinSourceMap>>`
	`68`	`+BuiltinLoader::GetBuiltinIds() const {`
	`69`	`+return std::views::keys(*source_.read());`
	`70`	`+}`
	`71`	`+`
`67`	`72`	`bool BuiltinLoader::Exists(const char* id) {`
`68`	`73`	`auto source = source_.read();`
`69`	`74`	`return source->find(id) != source->end();`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -127,9 +127,9 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {`
`127`	`127`
`128`	`128`	`void CopySourceAndCodeCacheReferenceFrom(const BuiltinLoader* other);`
`129`	`129`
`130`		`- [[nodiscard]] auto GetBuiltinIds() const {`
`131`		`-return std::views::keys(*source_.read());`
`132`		`-}`
	`130`	`+ [[nodiscard]] std::ranges::keys_view<`
	`131`	`+ std::ranges::ref_view<const BuiltinSourceMap>>`
	`132`	`+GetBuiltinIds() const;`
`133`	`133`
`134`	`134`	`void SetEagerCompile() { should_eager_compile_ = true; }`
`135`	`135`