Home Original page

test: updated test-domain-exit-dispose-again by Ethan-Arrowood · Pull Request #10003 · nodejs/node

@Ethan-Arrowood 

setTimeout at 49:5 requires two arguments, so I added
TIMEOUT_DURATION as the second argument. On lines 72
and 73 changed assert.equal() to assert.strictEqual().

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Dec 1, 2016

@imyller imyller added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Dec 1, 2016

@mscdex mscdex added the domain

Issues and PRs related to the domain subsystem.

label

Dec 1, 2016

Fishrock123

Trott pushed a commit to Trott/io.js that referenced this pull request

Dec 7, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: nodejs#10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 8, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: nodejs#10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 20, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Dec 21, 2016