Home Original page

test: Refactors variables to ES6 compatible and newer assertions by shri3k · Pull Request #10023 · nodejs/node

added 2 commits

December 1, 2016 11:27
- changes var to const/let
- changes assert.equal to assert.strictEqual

**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**
- changes var to const/let
- change assert.equal to assert.strictEqual

**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**

@imyller imyller added code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

tls

Issues and PRs related to the tls subsystem.

labels

Dec 1, 2016

mcollina

cjihrig

@shri3k 

- changes `notEqual` to `notStrictEqual`

mcollina pushed a commit that referenced this pull request

Dec 7, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: #10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 8, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: #10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: nodejs#10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 20, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: #10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: #10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: #10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This was referenced

Dec 21, 2016