doc: update `path.format` description and examples by anoff · Pull Request #10046 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@anoff

Copy link

Contributor

@anoff anoff commented

Dec 1, 2016

This came up while talking to @sam-github during the code-and-learn

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
  • removed pseudo-code
  • rename pathObject to options to improve readability
  • added info on which properties have priority
  • modified examples to show ignored properties

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@thefourtheye thefourtheye thefourtheye left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

doc

Issues and PRs related to the documentations.

path

Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anoff @Trott @sam-github @jasnell @thefourtheye @MylesBorins @imyller @nodejs-github-bot