test: improve test-child-process-fork-and-spawn by edsadr · Pull Request #10273 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@edsadr

Copy link

Member

@edsadr edsadr commented

Dec 15, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use const instead of var for required modules
  • use assert.strictEqual instead of assert.equal

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

+2 more reviewers

@evanlucas evanlucas evanlucas approved these changes

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test

Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@edsadr @santigimeno @lpinca @JungMinu @italoacasas @evanlucas @cjihrig @MylesBorins @nodejs-github-bot