Home Original page

Fix timers cancel in interval v4.x by Fishrock123 · Pull Request #10365 · nodejs/node

@Fishrock123 

Previously not all codepaths set `timer._idleTimeout = -1` for canceled
or closed timers, and not all codepaths checked it either.

Unenroll uses this to say that a timer is indeed closed and it is the
closest thing there is to an authoritative source for this.

Refs: nodejs#9606
Fixes: nodejs#9561
PR-URL: nodejs#9685
Reviewed-By: Rich Trott <rtrott@gmail.com>

 Conflicts:
	lib/timers.js

@Fishrock123 added timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

v4.x labels

Dec 21, 2016

@Fishrock123

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
PR-URL: #10365
Ref: #9685

Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
PR-URL: #10365
Ref: #9685

Reviewed-By: Myles Borins <myles.borins@gmail.com>