Home Original page

events: improve removeListener() performance by mscdex · Pull Request #10572 · nodejs/node

@mscdex added events

Issues and PRs related to the events subsystem / EventEmitter.

performance

Issues and PRs related to the performance of Node.js.

labels

Jan 2, 2017

benjamingr

mhdawson

@mscdex 

array.shift() seems to be faster than arrayClone() when the item
to remove is at the front (at least with V8 5.4).

PR-URL: nodejs#10572
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@mscdex mscdex deleted the events-removelistener-perf branch

January 5, 2017 07:57

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 18, 2017 
array.shift() seems to be faster than arrayClone() when the item
to remove is at the front (at least with V8 5.4).

PR-URL: nodejs#10572
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 19, 2017 
array.shift() seems to be faster than arrayClone() when the item
to remove is at the front (at least with V8 5.4).

PR-URL: nodejs#10572
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 24, 2017 
array.shift() seems to be faster than arrayClone() when the item
to remove is at the front (at least with V8 5.4).

PR-URL: nodejs#10572
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 27, 2017 
array.shift() seems to be faster than arrayClone() when the item
to remove is at the front (at least with V8 5.4).

PR-URL: nodejs#10572
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>