v7.x backport - doc: correct vcbuild options for windows testing by gibfahn · Pull Request #10686 · nodejs/node

@gibfahn added doc

Issues and PRs related to the documentations.

windows

Issues and PRs related to the Windows platform.

labels

Jan 8, 2017

@jboarman @gibfahn

Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

@gibfahn gibfahn changed the base branch from master to v7.x-staging

January 8, 2017 15:20

@mscdex mscdex added the build

Issues and PRs related to build files or the CI.

label

Jan 8, 2017

bzoz

bzoz approved these changes Jan 10, 2017

jasnell pushed a commit that referenced this pull request

Jan 10, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

@gibfahn gibfahn changed the title doc: correct vcbuild options for windows testing v7.x - doc: correct vcbuild options for windows testing

Jan 16, 2017

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 18, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: nodejs#10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

@gibfahn gibfahn changed the title v7.x - doc: correct vcbuild options for windows testing v7.x backport - doc: correct vcbuild options for windows testing

Jan 19, 2017

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 23, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: nodejs#10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 24, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: nodejs#10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 27, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: nodejs#10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

joaocgreis pushed a commit that referenced this pull request

Feb 8, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

joaocgreis pushed a commit that referenced this pull request

Feb 9, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2017
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>