doc: tls API for direct TLS socket use by sam-github · Pull Request #10846

doc: tls API for direct TLS socket use by sam-github · Pull Request #10846 · nodejs/node

added doc

Issues and PRs related to the documentations.

test

Issues and PRs related to the tests.

tls

Issues and PRs related to the tls subsystem.

labels

Jan 17, 2017

Direct use of tls.TLSSocket to start a TLS session over an existing TCP connection was documented.

However, to use this connection securely it is necessary to validate and
authenticate the peer's certificate, and the documented events and
properties are implemented only for TLSSockets returned by
tls.connect(). In order to create secure connections, additional
undocumented APIs must be used, and these APIs are being called right
now by npm modules.

Fix: nodejs#10555
Fix: nodejs#11467

jasnell added a commit to jasnell/node that referenced this pull request

Nov 1, 2018

deprecate the legacy undocumented `.ssl` alias for the
`TLSSocket._handle` and document alternatives. Document
how to properly use the `TLSSocket` constructor directly.

Updated take on nodejs#10846

Fixes: nodejs#10555

jasnell added a commit to jasnell/node that referenced this pull request

Dec 31, 2020

Fixes: nodejs#10555
Refs: nodejs#10846

The `new tls.TLSSocket()` constructor does not set up all of the
necessary lifecycle management or event handlers necessary for
proper use. The `tls.connect()` method really should be the way
that all `tls.TLSSocket()` instances are created. This commit
begins the eventual phasing out of the `new tls.TLSSocket()`
constructor with a doc-only deprecation.

Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell added a commit to jasnell/node that referenced this pull request

Apr 28, 2021