src: make copies of startup environment variables by bnoordhuis · Pull Request #11051 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bnoordhuis

Copy link

Member

@bnoordhuis bnoordhuis commented

Jan 28, 2017

edited

Loading

Mutations of the environment can invalidate pointers to environment
variables, so make secure_getenv() copy them out instead of returning
pointers.

cc @sam-github

CI: https://ci.nodejs.org/job/node-test-pull-request/6087/

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@sam-github sam-github sam-github approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

i18n-api

Issues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis @gibfahn @jasnell @sam-github @italoacasas @MylesBorins @srl295 @addaleax @nodejs-github-bot