tools: add ASCII only lint rule in lib/ by hkal · Pull Request #11371 · nodejs/node

@nodejs-github-bot added timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

tools

Issues and PRs related to the tools directory.

labels

Feb 14, 2017

mscdex

addaleax

@aqrln aqrln mentioned this pull request

Feb 16, 2017

2 tasks

aqrln added a commit to aqrln/node that referenced this pull request

Feb 16, 2017
In order to allow using Unicode characters inside comments of built-in
JavaScript libraries without forcing them to be stored as UTF-16 data in
Node's binary, update the tooling to strip comments during build
process. All line breaks are preserved so that line numbers in stack
traces aren't broken.

Refs: nodejs#11129
Refs: nodejs#11371 (comment)

@aqrln aqrln mentioned this pull request

Feb 17, 2017

3 tasks

aqrln

aqrln

aqrln

@hkal

Detects if files in lib/ contain non-ASCII characters and
raises a linting error. Also removes non-ASCII characters
from lib/console.js comments

Fixes: nodejs#11209

not-an-aardvark

Trott

This was referenced

Jan 4, 2018