Home Original page

test: fix flaky test-domain-abort-on-uncaught by Trott · Pull Request #11817 · nodejs/node

@Trott added domain

Issues and PRs related to the domain subsystem.

test

Issues and PRs related to the tests.

labels

Mar 12, 2017

@Trott 

test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: nodejs#11814

@Trott Trott changed the title test: move flaky test to sequential test: fix flaky test-domain-abort-on-uncaught

Mar 12, 2017

@Trott Trott mentioned this pull request

Mar 12, 2017

santigimeno

jasnell pushed a commit that referenced this pull request

Mar 16, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Mar 20, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jungx098 pushed a commit to jungx098/node that referenced this pull request

Mar 21, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 18, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 19, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

andrew749 pushed a commit to michielbaird/node that referenced this pull request

Jul 19, 2017 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs/node#11817
Fixes: nodejs/node#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the flaky-domain-test branch

January 13, 2022 22:45