test: minor fixups for REPL eval tests by addaleax · Pull Request #11946

test: minor fixups for REPL eval tests by addaleax · Pull Request #11946 · nodejs/node

Conversation

The process.on("exit") event handlers are unnecessary, so it’s okay
to drop them.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test,repl

The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

Ref: nodejs#11871

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jasnell pushed a commit that referenced this pull request

Mar 22, 2017

The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Conversation

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

Labels