Home Original page

path: reduce type checking on some methods by cjihrig · Pull Request #1216 · nodejs/node

@cjihrig 

a465840 added strict type
checking for the methods in the path module. However, dirname(),
basename(), and extname() actually had some undocumented uses
in the wild. This commit loosens the type checking on those
methods.

added a commit that referenced this pull request

Mar 20, 2015 
a465840 added strict type
checking for the methods in the path module. However, dirname(),
basename(), and extname() actually had some undocumented uses
in the wild. This commit loosens the type checking on those
methods.

Fixes: #1215
PR-URL: #1216
Reviewed-By: Rod Vagg <rod@vagg.org>

@rvagg rvagg mentioned this pull request

Mar 20, 2015

rvagg added a commit that referenced this pull request

Mar 20, 2015 
Notable Changes:

* path: New type-checking on path.resolve()
  <#1153> uncovered some edge-cases
  being relied upon in the wild, most notably path.dirname(undefined).
  Type-checking has been loosened for path.dirname(), path.basename(),
  and path.extname(), (Colin Ihrig)
  <#1216>.
* querystring: Internal optimizations in querystring.parse() and
  querystring.stringify() <#847>
  prevented Number literals from being properly converted via
  querystring.escape() <#1208>,
  exposing a blind-spot in the test suite. The bug and the tests have
  now been fixed (Jeremiah Senkpiel)
  <#1213>.

This was referenced

Apr 24, 2023

This was referenced

Apr 26, 2023

This was referenced

Apr 27, 2023

This was referenced

Jul 8, 2023

This was referenced

Nov 30, 2023

This was referenced

Nov 30, 2023

This was referenced

Dec 1, 2023

This was referenced

Dec 2, 2023

This was referenced

Dec 2, 2023

This was referenced

Dec 3, 2023