lib: don't penalize setInterval/setTimeout common case by bnoordhuis · Pull Request #1221 · nodejs/node

added 3 commits

March 20, 2015 23:42
The common case is where setTimeout() is called with two arguments,
the callback and the timeout.  Specifying optional arguments in the
parameter list forces common case calls to go through an arguments
adaptor stack frame.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
The common case is where setInterval() is called with two arguments,
the callback and the timeout.  Specifying optional arguments in
the parameter list forces common case calls to go through an arguments
adaptor stack frame.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
It turns out we have little to no test coverage for setTimeout() and
setInterval() calls with optional arguments.  Now we do.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

@rvagg rvagg mentioned this pull request

Mar 22, 2015