Home Original page

test: use dynamic port in test-dgram-bind-shared-ports by orafaelfragoso · Pull Request #12452 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Apr 16, 2017

santigimeno

@santigimeno santigimeno added cluster

Issues and PRs related to the cluster subsystem.

dgram

Issues and PRs related to the dgram subsystem / UDP.

labels

Apr 16, 2017 
Use of common.PORT in parallel tests is not completely safe (because
the same port can be previously assigned to another test running in
parallel if that test uses port 0 to get an arbitrary available port).

Remove common.PORT from test-dgram-bind-shared-ports.
Adding a common.mustCall() to socket1 callback on
test-dgram-bind-shared-ports to make sure the callback
is being called.

@orafaelfragoso 

Restoring the contents of the test to it's original with common.PORT()

Refs: nodejs#12376

lpinca pushed a commit to lpinca/node that referenced this pull request

May 13, 2017 
PR-URL: nodejs#12452
Ref: nodejs#12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@Trott Trott mentioned this pull request

May 13, 2017

64 tasks

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
PR-URL: nodejs#12452
Ref: nodejs#12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 22, 2017 
PR-URL: #12452
Ref: #12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
PR-URL: #12452
Ref: #12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>