Home Original page

tests: remove common.PORT from cluster worker wait server close by sebastianplesciuc · Pull Request #12466 · nodejs/node

Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

Refs: #12376

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Apr 17, 2017

santigimeno

@mscdex mscdex added the cluster

Issues and PRs related to the cluster subsystem.

label

Apr 17, 2017

@Trott Trott mentioned this pull request

Apr 17, 2017

64 tasks

jasnell pushed a commit that referenced this pull request

Apr 19, 2017 
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12466
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

gibfahn pushed a commit that referenced this pull request

Jun 18, 2017 
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12466
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

gibfahn pushed a commit that referenced this pull request

Jun 20, 2017 
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12466
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12466
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>