Home Original page

src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h by danbev · Pull Request #12638 · nodejs/node

@danbev 

As indicated by the FIXME comment, this macro guard is no longer needed.

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Apr 25, 2017

bnoordhuis

addaleax pushed a commit that referenced this pull request

Apr 27, 2017 
As indicated by the FIXME comment, this macro guard is no longer needed.

PR-URL: #12638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@danbev danbev deleted the remove-gtest-macro-guard branch

June 28, 2017 05:41

danbev added a commit to danbev/node that referenced this pull request

Aug 15, 2017 
As indicated by the FIXME comment, this macro guard is no longer needed.

PR-URL: nodejs#12638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request

Aug 16, 2017 
As indicated by the FIXME comment, this macro guard is no longer needed.

PR-URL: #12638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request

Sep 5, 2017 
As indicated by the FIXME comment, this macro guard is no longer needed.

PR-URL: #12638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was referenced

Sep 5, 2017

This was referenced

Sep 6, 2017