Home Original page

test: replace port in cluster dgram reuse test by arturgvieira-zz · Pull Request #12901 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 8, 2017

arturgvieira-zz

Trott

Trott

Trott

Trott

Trott previously requested changes May 8, 2017

@arturgvieira-zz arturgvieira-zz changed the title test: remove common.PORT or move test to sequential test: replace common.PORT with zero

May 9, 2017

@arturgvieira-zz arturgvieira-zz changed the title test: replace common.PORT with zero test: replace port in cluster dgram reuse test

May 10, 2017

lpinca

@vieiraarturg 

Replaced common.PORT with zero in the following test.
test-cluster-dgram-reuse.js

Refs: #12376

mcollina

@mscdex mscdex added cluster

Issues and PRs related to the cluster subsystem.

dgram

Issues and PRs related to the dgram subsystem / UDP.

labels

May 19, 2017

lpinca pushed a commit that referenced this pull request

May 19, 2017 
Remove common.PORT from test-cluster-dgram-reuse to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12901
Ref: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

@Trott Trott mentioned this pull request

May 19, 2017

64 tasks

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
Remove common.PORT from test-cluster-dgram-reuse to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: nodejs#12901
Ref: nodejs#12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

@Trott Trott mentioned this pull request

May 20, 2017

1 task

MylesBorins pushed a commit that referenced this pull request

Jul 17, 2017 
Remove common.PORT from test-cluster-dgram-reuse to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12901
Ref: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>