Home Original page

test: replace port in https address family test by arturgvieira-zz · Pull Request #12915 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 9, 2017

@mscdex mscdex added the https

Issues or PRs related to the https subsystem.

label

May 9, 2017

thefourtheye

@vieiraarturg 

Replaced common.PORT with zero in the following test.
test-https-connect-address-family.js

Refs: #12376

@arturgvieira-zz arturgvieira-zz changed the title test: replace common.PORT with zero test: replace port in https address family test

May 10, 2017

lpinca pushed a commit to lpinca/node that referenced this pull request

May 12, 2017 
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: nodejs#12915
Ref: nodejs#12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@Trott Trott mentioned this pull request

May 12, 2017

64 tasks

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: nodejs#12915
Ref: nodejs#12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 22, 2017 
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12915
Ref: #12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12915
Ref: #12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>