Home Original page

test: replace port in dgram cb address test by arturgvieira-zz · Pull Request #12944 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 10, 2017

@mscdex mscdex added the dgram

Issues and PRs related to the dgram subsystem / UDP.

label

May 10, 2017

@arturgvieira-zz arturgvieira-zz changed the title test: remove common.PORT from test test: replace port in dgram cb address test

May 10, 2017

@arturgvieira-zz arturgvieira-zz changed the title test: replace port in dgram cb address test test: move to sequential dgram cb address test

May 10, 2017

@arturgvieira-zz arturgvieira-zz changed the title test: move to sequential dgram cb address test test: replace port in dgram cb address test

May 11, 2017

lpinca

@vieiraarturg 

Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length-empty-address.js

Ref: #12376

mhdawson

lpinca pushed a commit that referenced this pull request

May 22, 2017 
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

@Trott Trott mentioned this pull request

May 22, 2017

64 tasks

jasnell pushed a commit that referenced this pull request

May 23, 2017 
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

jasnell pushed a commit that referenced this pull request

May 23, 2017 
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12944
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>