Home Original page

test: replace port in dgram send address types test by arturgvieira-zz · Pull Request #13007 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 12, 2017

@hiroppy hiroppy added the dgram

Issues and PRs related to the dgram subsystem / UDP.

label

May 13, 2017

lpinca

lpinca

@vieiraarturg 

Replaced common.PORT in the following test.
test-dgram-send-address-types.js

Ref: #12376

lpinca pushed a commit that referenced this pull request

May 22, 2017 
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@Trott Trott mentioned this pull request

May 22, 2017

64 tasks

jasnell pushed a commit that referenced this pull request

May 23, 2017 
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request

May 23, 2017 
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>