Home Original page

test: increase n-api constructor coverage by mhdawson · Pull Request #13124 · nodejs/node

@mhdawson 

Add tests to validate that properties marked as static
are available through the class as opposed to instances

@nodejs-github-bot added node-api

Issues and PRs related to the Node-API.

test

Issues and PRs related to the tests.

labels

May 19, 2017

@mhdawson

jasongin

digitalinfinity

addaleax pushed a commit that referenced this pull request

May 23, 2017 
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

jasnell pushed a commit that referenced this pull request

May 24, 2017 
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

jasnell pushed a commit that referenced this pull request

May 28, 2017 
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request

Apr 10, 2018 
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: nodejs#13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 16, 2018 
Add tests to validate that properties marked as static
are available through the class as opposed to instances

Backport-PR-URL: #19447
PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>