Home Original page

readline: clean up event listener in onNewListener by gibfahn · Pull Request #13266 · nodejs/node

@nodejs-github-bot added the readline

Issues and PRs related to the built-in readline module.

label

May 28, 2017 
Once the Readline interface is closed, the 'data' event listener should
be removed.

Refs: nodejs#9447 (comment)

@gibfahn

@gibfahn

jasnell pushed a commit that referenced this pull request

Jun 1, 2017 
Once the Readline interface is closed, the 'data' event listener should
be removed.

PR-URL: #13266
Ref: #9447 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn deleted the readline-listener branch

June 2, 2017 08:22

jasnell pushed a commit that referenced this pull request

Jun 5, 2017 
Once the Readline interface is closed, the 'data' event listener should
be removed.

PR-URL: #13266
Ref: #9447 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Jun 8, 2017

@addaleax

addaleax added a commit that referenced this pull request

Jun 10, 2017 
This reverts commit 81ddeb9.

Ref: #13266
PR-URL: #13560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request

Jun 10, 2017 
This reverts commit 81ddeb9.

Ref: #13266
PR-URL: #13560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>