Home Original page

async_hooks,http: fix socket reuse with Agent by addaleax · Pull Request #13348 · nodejs/node

@addaleax 

Under very specific circumstances the `http` implementation
could be brought to crash, because the Agent did not re-assign
the async id field properly after setting up a socket for reuse.

Fixes: nodejs#13325

@addaleax added async_hooks

Issues and PRs related to the async hooks subsystem.

http

Issues or PRs related to the http subsystem.

labels

May 31, 2017

addaleax

refack

AndreasMadsen

Trott

addaleax added a commit that referenced this pull request

Jun 3, 2017 
Under very specific circumstances the `http` implementation
could be brought to crash, because the Agent did not re-assign
the async id field properly after setting up a socket for reuse.

Fixes: #13325
PR-URL: #13348
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

jasnell pushed a commit that referenced this pull request

Jun 5, 2017 
Under very specific circumstances the `http` implementation
could be brought to crash, because the Agent did not re-assign
the async id field properly after setting up a socket for reuse.

Fixes: #13325
PR-URL: #13348
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>